Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-3228] Currently interpreter dependencies are not downloaded on zeppelin start - regression issue #2792

Closed
wants to merge 1 commit into from

Conversation

jhonderson
Copy link

@jhonderson jhonderson commented Feb 12, 2018

Currently interpreter dependencies are not downloaded on zeppelin start. This was solved in [ZEPPELIN-3228], but it is happening again.

What is this PR for?

When zeppelin is started/restarted, server should try and download interpreter dependencies.

What type of PR is it?

[Bug Fix]

What is the Jira issue?

How should this be tested?

  • Put a dependency (say "org.apache.commons:commons-csv:1.1") in any of the interpreter.
  • From command line delete local-repo directory
  • Restart zeppelin server

Expectation is local-repo should be recreated with all the dependencies that were mentioned in any of the interpreters.

Questions:

  • Does the licenses files need update? n/a
  • Is there breaking changes for older versions? n/a
  • Does this needs documentation? n/a

@zjffdu
Copy link
Contributor

zjffdu commented Feb 13, 2018

LGTM

Copy link
Contributor

@prabhjyotsingh prabhjyotsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjffdu
Copy link
Contributor

zjffdu commented Feb 13, 2018

@jhonderson ZEPPELIN-1143 has been fixed. Is this a regression issue ? If so, could you create another ticket for this issue ?

@jhonderson jhonderson changed the title [ZEPPELIN-1143] Currently interpreter dependencies are not downloaded on zeppelin start [ZEPPELIN-3228] Currently interpreter dependencies are not downloaded on zeppelin start - regression issue Feb 13, 2018
@jhonderson
Copy link
Author

@zjffdu i have created the ticket for this issue. If this is approved, could you please merge this solution to branch-0.8?

@zjffdu
Copy link
Contributor

zjffdu commented Feb 13, 2018

Thanks @jhonderson , will merge it to branch-0.8 if CI pass

@zjffdu
Copy link
Contributor

zjffdu commented Feb 14, 2018

@jhonderson Can you retrigger the build (via close and reopen), I can not access your jenkins job

@jhonderson
Copy link
Author

Re-triggering build.

@jhonderson jhonderson closed this Feb 14, 2018
@jhonderson jhonderson reopened this Feb 14, 2018
@jhonderson
Copy link
Author

@zjffdu by the way, here is my travis: https://travis-ci.org/jhonderson/zeppelin/builds/340723065

asfgit pushed a commit that referenced this pull request Feb 14, 2018
… on zeppelin start - regression issue

Currently interpreter dependencies are not downloaded on zeppelin start. This was solved in [ZEPPELIN-3228], but it is happening again.

### What is this PR for?
When zeppelin is started/restarted, server should try and download interpreter dependencies.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3228]

### How should this be tested?
*  Put a dependency (say "org.apache.commons:commons-csv:1.1") in any of the interpreter.
*  From command line delete local-repo directory
*  Restart zeppelin server

Expectation is local-repo should be recreated with all the dependencies that were mentioned in any of the interpreters.

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

Author: Cardenas, Jhon <ext-jhon.cardenas@here.com>

Closes #2792 from jhonderson/ZEPPELIN-1143 and squashes the following commits:

3fcefb2 [Cardenas, Jhon] [ZEPPELIN-1143] When zeppelin starts it does the interpreter dependencies loading.

(cherry picked from commit 3418055)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
@asfgit asfgit closed this in 3418055 Feb 14, 2018
necosta pushed a commit to nokia/zeppelin that referenced this pull request Feb 14, 2018
… on zeppelin start - regression issue

Currently interpreter dependencies are not downloaded on zeppelin start. This was solved in [ZEPPELIN-3228], but it is happening again.

When zeppelin is started/restarted, server should try and download interpreter dependencies.

[Bug Fix]

* [ZEPPELIN-3228]

*  Put a dependency (say "org.apache.commons:commons-csv:1.1") in any of the interpreter.
*  From command line delete local-repo directory
*  Restart zeppelin server

Expectation is local-repo should be recreated with all the dependencies that were mentioned in any of the interpreters.

* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

Author: Cardenas, Jhon <ext-jhon.cardenas@here.com>

Closes apache#2792 from jhonderson/ZEPPELIN-1143 and squashes the following commits:

3fcefb2 [Cardenas, Jhon] [ZEPPELIN-1143] When zeppelin starts it does the interpreter dependencies loading.
@jhonderson jhonderson deleted the ZEPPELIN-1143 branch March 14, 2018 17:48
jwagun pushed a commit to jwagun/zeppelin that referenced this pull request Apr 23, 2018
… on zeppelin start - regression issue

Currently interpreter dependencies are not downloaded on zeppelin start. This was solved in [ZEPPELIN-3228], but it is happening again.

### What is this PR for?
When zeppelin is started/restarted, server should try and download interpreter dependencies.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3228]

### How should this be tested?
*  Put a dependency (say "org.apache.commons:commons-csv:1.1") in any of the interpreter.
*  From command line delete local-repo directory
*  Restart zeppelin server

Expectation is local-repo should be recreated with all the dependencies that were mentioned in any of the interpreters.

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

Author: Cardenas, Jhon <ext-jhon.cardenas@here.com>

Closes apache#2792 from jhonderson/ZEPPELIN-1143 and squashes the following commits:

3fcefb2 [Cardenas, Jhon] [ZEPPELIN-1143] When zeppelin starts it does the interpreter dependencies loading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants