[ZEPPELIN-3628] HTML anchor links on paragraph don't work in Google Chrome #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. BTW, Is there any way to remove bower dependency? I'd like to move this to a newer package manager. |
egorklimov
changed the title
|
Something went wrong with dependencies: after that update, cursor stopped moving in paragraph text using keyboard arrows. |
|
@jongyoul I could try to migrate away from bower to npm/yarn |
|
Seems that in updated
|
egorklimov
changed the title
|
@jongyoul I decided that it would be too hard for me to migrate away from bower to yarn now, maybe I'll try to do this later. |
|
You need to enable travis for testing this PR. Unfortunately, it only supports user id's travis. Can you handle it? |
egorklimov
force-pushed
the
ZEPPELIN-3628
branch
from
29a3be7
to
3757129
Compare
|
Will merge if no more comment |
asfgit
pushed a commit
that referenced
this pull request
Jul 31, 2018
…hrome ### What is this PR for? Links like [1] work well in Firefox, but don't work in Chrome. 1. http://zeppelin/#/notebook/NOTEID?paragraph=PARAGRAPHID ### What type of PR is it? Improvement ### What is the Jira issue? issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3628 ### How should this be tested? * Manual checking (see screenshot below) ### Screenshots (if appropriate) * #### Before Chrome (v67.0.3396.99):  Firefox (v61.0.1):  * #### After Chrome (v67.0.3396.99)  ### Questions: * Does the licenses files need update? Yes, JQuery.scrollTo changed from 1.4.14 to 2.1.2 * Is there breaking changes for older versions? No * Does this needs documentation? No Author: egorklimov <klim.electronicmail@gmail.com> Closes #3078 from egorklimov/ZEPPELIN-3628 and squashes the following commits: 3757129 [egorklimov] Cursor in paragraph text fixed 8b521f8 [egorklimov] License github link fixed e2ead10 [egorklimov] jQuery ScrollTo license updated 87ac4ac [egorklimov] jQuery ScrollTo updated (cherry picked from commit e71fac3) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
…hrome ### What is this PR for? Links like [1] work well in Firefox, but don't work in Chrome. 1. http://zeppelin/#/notebook/NOTEID?paragraph=PARAGRAPHID ### What type of PR is it? Improvement ### What is the Jira issue? issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3628 ### How should this be tested? * Manual checking (see screenshot below) ### Screenshots (if appropriate) * #### Before Chrome (v67.0.3396.99):  Firefox (v61.0.1):  * #### After Chrome (v67.0.3396.99)  ### Questions: * Does the licenses files need update? Yes, JQuery.scrollTo changed from 1.4.14 to 2.1.2 * Is there breaking changes for older versions? No * Does this needs documentation? No Author: egorklimov <klim.electronicmail@gmail.com> Closes apache#3078 from egorklimov/ZEPPELIN-3628 and squashes the following commits: 3757129 [egorklimov] Cursor in paragraph text fixed 8b521f8 [egorklimov] License github link fixed e2ead10 [egorklimov] jQuery ScrollTo license updated 87ac4ac [egorklimov] jQuery ScrollTo updated
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
…hrome ### What is this PR for? Links like [1] work well in Firefox, but don't work in Chrome. 1. http://zeppelin/#/notebook/NOTEID?paragraph=PARAGRAPHID ### What type of PR is it? Improvement ### What is the Jira issue? issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3628 ### How should this be tested? * Manual checking (see screenshot below) ### Screenshots (if appropriate) * #### Before Chrome (v67.0.3396.99):  Firefox (v61.0.1):  * #### After Chrome (v67.0.3396.99)  ### Questions: * Does the licenses files need update? Yes, JQuery.scrollTo changed from 1.4.14 to 2.1.2 * Is there breaking changes for older versions? No * Does this needs documentation? No Author: egorklimov <klim.electronicmail@gmail.com> Closes apache#3078 from egorklimov/ZEPPELIN-3628 and squashes the following commits: 3757129 [egorklimov] Cursor in paragraph text fixed 8b521f8 [egorklimov] License github link fixed e2ead10 [egorklimov] jQuery ScrollTo license updated 87ac4ac [egorklimov] jQuery ScrollTo updated (cherry picked from commit e71fac3) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Links like [1] work well in Firefox, but don't work in Chrome.
What type of PR is it?
Improvement
What is the Jira issue?
issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3628
How should this be tested?
Screenshots (if appropriate)
Before
Chrome (v67.0.3396.99):
Firefox (v61.0.1):
After
Chrome (v67.0.3396.99)
Questions:
Yes, JQuery.scrollTo changed from 1.4.14 to 2.1.2