[ZEPPELIN-3656] Fix for completion with Livy interpreter #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add unit test |
|
@zjffdu I've added a test and it builds in Travis: https://travis-ci.org/alexjbush/zeppelin/builds/407942421 Seems like it's failing to check out the code in Jenkins. Is there some reason for this? Also, how can this be applied to master and 0.8.1? Will you do the merge to 0.8.1 after this is merged to master? |
|
@alexjbush Not sure what's wrong with jenkins. Maybe you can try it later. |
|
@zjffdu Yes, but can this fix go into both master and branch-0.8 branches? Who will do this cherry picking for branch-0.8? All checks are now passing too. |
|
Don't worry, I will do the cherry-pick |
asfgit
pushed a commit
that referenced
this pull request
Jul 25, 2018
### What is this PR for? Fix for NullPointerException when using code completion in the Livy Interpreter when Shared Interpreter is enabled. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-3656](https://issues.apache.org/jira/browse/ZEPPELIN-3656) ### How should this be tested? Run Livy Interpreter in an environment where Shared Interpreter is enabled and attempt to trigger code completions. A unit test has been added to test the completion API when using a shared interpreter. Before applying the fix this test was failing with the same NPE. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alex Bush <alex.bush@coxauto.co.uk> Closes #3094 from alexjbush/ZEPPELIN-3656 and squashes the following commits: 4f4a875 [Alex Bush] Correct completion test cd0c213 [Alex Bush] Force a failing test 71562e0 [Alex Bush] Test IT for Changes 32aa7c5 [Alex Bush] [ZEPPELIN-3656] Fix for completion with Livy interpreter (cherry picked from commit 8769d41) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
### What is this PR for? Fix for NullPointerException when using code completion in the Livy Interpreter when Shared Interpreter is enabled. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-3656](https://issues.apache.org/jira/browse/ZEPPELIN-3656) ### How should this be tested? Run Livy Interpreter in an environment where Shared Interpreter is enabled and attempt to trigger code completions. A unit test has been added to test the completion API when using a shared interpreter. Before applying the fix this test was failing with the same NPE. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alex Bush <alex.bush@coxauto.co.uk> Closes apache#3094 from alexjbush/ZEPPELIN-3656 and squashes the following commits: 4f4a875 [Alex Bush] Correct completion test cd0c213 [Alex Bush] Force a failing test 71562e0 [Alex Bush] Test IT for Changes 32aa7c5 [Alex Bush] [ZEPPELIN-3656] Fix for completion with Livy interpreter
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
### What is this PR for? Fix for NullPointerException when using code completion in the Livy Interpreter when Shared Interpreter is enabled. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-3656](https://issues.apache.org/jira/browse/ZEPPELIN-3656) ### How should this be tested? Run Livy Interpreter in an environment where Shared Interpreter is enabled and attempt to trigger code completions. A unit test has been added to test the completion API when using a shared interpreter. Before applying the fix this test was failing with the same NPE. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alex Bush <alex.bush@coxauto.co.uk> Closes apache#3094 from alexjbush/ZEPPELIN-3656 and squashes the following commits: 4f4a875 [Alex Bush] Correct completion test cd0c213 [Alex Bush] Force a failing test 71562e0 [Alex Bush] Test IT for Changes 32aa7c5 [Alex Bush] [ZEPPELIN-3656] Fix for completion with Livy interpreter (cherry picked from commit 8769d41) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix for NullPointerException when using code completion in the Livy Interpreter when Shared Interpreter is enabled.
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-3656
How should this be tested?
Run Livy Interpreter in an environment where Shared Interpreter is enabled and attempt to trigger code completions.
A unit test has been added to test the completion API when using a shared interpreter. Before applying the fix this test was failing with the same NPE.
Screenshots (if appropriate)
Questions: