Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-4325: Fix bug when list "/" with ZkUtil::listSubTreeBFS #1719

Closed
wants to merge 12 commits into from
Closed

ZOOKEEPER-4325: Fix bug when list "/" with ZkUtil::listSubTreeBFS #1719

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
56d88c2
Fix ZOOKEEPER-4325.
autumind Jun 26, 2021
3ee4621
Add unit tests for ZOOKEEPER-4325
autumind Jun 26, 2021
f4fb51d
Fix unit tests
autumind Jun 26, 2021
bf3d5cb
Change assert way.
autumind Jun 26, 2021
997d445
Fix assert imports.
autumind Jun 26, 2021
b5d5a6a
Remove redundant blank lines
autumind Jun 26, 2021
9cfa086
Remove trailing whitespace in comment
autumind Jun 26, 2021
2f91f30
Merge pull request #1 from autumind/autumind-patch-1
autumind Jun 26, 2021
d7b2767
Add more unit cases for BUG[ZOOKEEPER-4325]
autumind Jun 29, 2021
c2ab36c
Remove redundant imports
autumind Jun 29, 2021
60e4ba7
Remove empty line at the end of the file
autumind Jul 7, 2021
674019d
Re-trigger CI.
autumind Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ public static List<String> listSubTreeBFS(
String node = queue.poll();
List<String> children = zk.getChildren(node, false);
for (final String child : children) {
final String childPath = node + "/" + child;
// Fix "//some_path" bugs when list "/"
final String childPath = (node.equals("/") ? "" : node) + "/" + child;
queue.add(childPath);
tree.add(childPath);
}
Expand Down Expand Up @@ -290,4 +291,4 @@ public static String aclToString(List<ACL> acls) {
}
return sb.toString();
}
}
}
autumind marked this conversation as resolved.
Show resolved Hide resolved