Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String #1819

Closed
wants to merge 2 commits into from
Closed

ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String #1819

wants to merge 2 commits into from

Conversation

kezhuw
Copy link
Member

@kezhuw kezhuw commented Feb 22, 2022

Changes:

  • Format OpCode.addWatch as "addWatch" in Request.op2String.

maoling
maoling reviewed Mar 4, 2022
View reviewed changes
zookeeper-server/src/test/java/org/apache/zookeeper/server/ToStringTest.java Outdated
assertNotEquals(0, fields.length);

for (Field field : fields) {
int op_code = field.getInt(null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Camel-Case. e.g. op_code --> opCode
  2. we should assert here assertEquals(field.getName(), opString); ? (Of course we need to modify createTTL). When adding a new OpCode, this unit case can tell us: don't forget the method: Request.op2String

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed a fixup commit with changes requested.

@kezhuw kezhuw requested a review from maoling March 4, 2022 10:45
@maoling
Copy link
Member

maoling commented Apr 2, 2022

If no other concerns, I'll merge it at this weekend(04-05). Cc @kezhuw

@eolivelli
Copy link
Contributor

@maoling please always ensure that CI passes before merging

@maoling
Copy link
Member

maoling commented Apr 5, 2022

@asfgit asfgit closed this in 5b12b0e Apr 5, 2022
@anuragmadnawat1 anuragmadnawat1 mentioned this pull request Nov 1, 2022
Merged
anuragmadnawat1 pushed a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 1, 2022
@kezhuw @anurag-harness
ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String
ac5596b 
Changes:
* Format `OpCode.addWatch` as "addWatch" in `Request.op2String`.

Author: Kezhu Wang <kezhuw@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, maoling <maoling@apache.org>

Closes apache#1819 from kezhuw/ZOOKEEPER-4467-op_code_addWatch_string and squashes the following commits:

97f891d [Kezhu Wang] fixup! ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String
ebe6faa [Kezhu Wang] ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String
anuragmadnawat1 added a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 1, 2022
@anuragmadnawat1 @kezhuw
ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String (#52)
88c6526 
Changes:
* Format `OpCode.addWatch` as "addWatch" in `Request.op2String`.

Author: Kezhu Wang <kezhuw@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, maoling <maoling@apache.org>

Closes apache#1819 from kezhuw/ZOOKEEPER-4467-op_code_addWatch_string and squashes the following commits:

97f891d [Kezhu Wang] fixup! ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String
ebe6faa [Kezhu Wang] ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String

Co-authored-by: Kezhu Wang <kezhuw@gmail.com>
anurag-harness pushed a commit to anurag-harness/zookeeper that referenced this pull request Jan 13, 2023
@kezhuw @anurag-harness
ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String
db36960 
Changes:
* Format `OpCode.addWatch` as "addWatch" in `Request.op2String`.

Author: Kezhu Wang <kezhuw@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, maoling <maoling@apache.org>

Closes apache#1819 from kezhuw/ZOOKEEPER-4467-op_code_addWatch_string and squashes the following commits:

97f891d [Kezhu Wang] fixup! ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String
ebe6faa [Kezhu Wang] ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String
@anurag-harness anurag-harness mentioned this pull request Jan 13, 2023
Merged
anurag-harness added a commit to anurag-harness/zookeeper that referenced this pull request Jan 13, 2023
@anurag-harness @kezhuw
ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String (#19)
e2f5b68 
Changes:
* Format `OpCode.addWatch` as "addWatch" in `Request.op2String`.

Author: Kezhu Wang <kezhuw@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, maoling <maoling@apache.org>

Closes apache#1819 from kezhuw/ZOOKEEPER-4467-op_code_addWatch_string and squashes the following commits:

97f891d [Kezhu Wang] fixup! ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String
ebe6faa [Kezhu Wang] ZOOKEEPER-4467: Format OpCode.addWatch in Request.op2String

Co-authored-by: Kezhu Wang <kezhuw@gmail.com>
@kezhuw kezhuw deleted the ZOOKEEPER-4467-op_code_addWatch_string branch September 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@maoling maoling Awaiting requested review from maoling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kezhuw @maoling @eolivelli