Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-4529 : Upgrade netty to 4.1.76.Final #1869

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-4529 : Upgrade netty to 4.1.76.Final #1869

wants to merge 1 commit into from

Conversation

AnanyaSingh2121
Copy link
Contributor

upgrading netty in master as per review in : #1867

@shoothzj
Copy link
Member

IMO, we should choose one cc @arshadmohammad

  • update tcnative version
  • remove tcnative version declaration

@AnanyaSingh2121
Copy link
Contributor Author

IMO, we should choose one cc @arshadmohammad

  • update tcnative version
  • remove tcnative version declaration

yes we will be removing tcnative version as a part of separate jira and PR so that it will be cleaner to track in future.

eolivelli
eolivelli requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update license files

@AnanyaSingh2121
Copy link
Contributor Author

please update license files

sure, will do

eolivelli
eolivelli approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks,
we will have to port this change to branch-3.8, branch-3.7 and branch-3.6

in case it does not apply cleanly we may ask you to send other patches

thank you very much !

arshadmohammad
arshadmohammad approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@arshadmohammad arshadmohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@asfgit asfgit closed this in aab3ff6 May 5, 2022
asfgit pushed a commit that referenced this pull request May 5, 2022
@AnanyaSingh2121 @arshadmohammad
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final
270359c 
upgrading netty in master as per review in : #1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes #1869 from AnanyaSingh2121/ZK-4529

(cherry picked from commit aab3ff6)
Signed-off-by: Mohammad Arshad <arshad@apache.org>
asfgit pushed a commit that referenced this pull request May 5, 2022
@AnanyaSingh2121 @arshadmohammad
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final
244640e 
upgrading netty in master as per review in : #1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes #1869 from AnanyaSingh2121/ZK-4529

(cherry picked from commit aab3ff6)
Signed-off-by: Mohammad Arshad <arshad@apache.org>
asfgit pushed a commit that referenced this pull request May 5, 2022
@AnanyaSingh2121 @arshadmohammad
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final
2548825 
upgrading netty in master as per review in : #1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes #1869 from AnanyaSingh2121/ZK-4529

(cherry picked from commit aab3ff6)
Signed-off-by: Mohammad Arshad <arshad@apache.org>
@arshadmohammad
Copy link
Contributor

@AnanyaSingh2121 pls raise the PR to remove tc-native

@AnanyaSingh2121
Copy link
Contributor Author

@AnanyaSingh2121 pls raise the PR to remove tc-native

Thanks @arshadmohammad for reviewing. Will raise PR for removing tcnative.

asfgit pushed a commit that referenced this pull request May 6, 2022
@AnanyaSingh2121 @arshadmohammad
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final
8e52cfa 
upgrading netty in master as per review in : #1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes #1869 from AnanyaSingh2121/ZK-4529

(cherry picked from commit aab3ff6)
Signed-off-by: Mohammad Arshad <arshad@apache.org>
anuragmadnawat1 pushed a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 1, 2022
@AnanyaSingh2121 @anurag-harness
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final
854573b 
upgrading netty in master as per review in : apache#1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes apache#1869 from AnanyaSingh2121/ZK-4529
@anuragmadnawat1 anuragmadnawat1 mentioned this pull request Nov 1, 2022
Merged
anuragmadnawat1 added a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 1, 2022
@anuragmadnawat1 @AnanyaSingh2121
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final (#59)
ab49822 
upgrading netty in master as per review in : apache#1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes apache#1869 from AnanyaSingh2121/ZK-4529

Co-authored-by: Ananya Singh <purpul90@gmail.com>
@anurag-harness anurag-harness mentioned this pull request Jan 13, 2023
Merged
anurag-harness pushed a commit to anurag-harness/zookeeper that referenced this pull request Jan 13, 2023
@AnanyaSingh2121 @anurag-harness
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final
734236e 
upgrading netty in master as per review in : apache#1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes apache#1869 from AnanyaSingh2121/ZK-4529
anurag-harness added a commit to anurag-harness/zookeeper that referenced this pull request Jan 13, 2023
@anurag-harness @AnanyaSingh2121
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final (#26)
7c4ecc6 
upgrading netty in master as per review in : apache#1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes apache#1869 from AnanyaSingh2121/ZK-4529

Co-authored-by: Ananya Singh <purpul90@gmail.com>
desaikomal pushed a commit to linkedin/zookeeper that referenced this pull request Jun 17, 2023
@AnanyaSingh2121 @desaikomal
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final
4c666ed 
upgrading netty in master as per review in : apache#1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes apache#1869 from AnanyaSingh2121/ZK-4529

(cherry picked from commit aab3ff6)
Signed-off-by: Mohammad Arshad <arshad@apache.org>
desaikomal pushed a commit to linkedin/zookeeper that referenced this pull request Jun 27, 2023
@AnanyaSingh2121 @desaikomal
ZOOKEEPER-4529: Upgrade netty to 4.1.76.Final
1af6f32 
upgrading netty in master as per review in : apache#1867

Author: Ananya Singh <purpul90@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org>

Closes apache#1869 from AnanyaSingh2121/ZK-4529

(cherry picked from commit aab3ff6)
Signed-off-by: Mohammad Arshad <arshad@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@arshadmohammad arshadmohammad arshadmohammad approved these changes

@symat symat Awaiting requested review from symat

@anmolnar anmolnar Awaiting requested review from anmolnar

@phunt phunt Awaiting requested review from phunt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnanyaSingh2121 @shoothzj @arshadmohammad @eolivelli