[ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'

[eolivelli]

Modifications:

• remove the block, as it is used only for debug

More details here:
https://issues.apache.org/jira/browse/ZOOKEEPER-4641

[anmolnar]

Approved.
It doesn't even compile?

[cnauroth]

I don't feel too strongly about it, but perhaps a more appropriate fix is:

#include <openssl/crypto.h>

I wonder why it was compiling before and stopped now.

[eolivelli]

@cnauroth
I am sorry I think I have pushed this patch to master branch by mistake.
The patch had been approved, I think there is no need to git revert.

wonder why it was compiling before and stopped now.

This is because we use -Werror and as long as the C compiler is upgraded we find more warnings, that are considered errors, this is why sometimes builds start to fail without anyone doing anything.

[eolivelli]

@cnauroth actually I hadn't pushed the patch to this repository but to my fork master branch.
So the patch is still here open for review

[cnauroth]

+1

Thank you, @eolivelli .

[symat]

LGTM
should I merge this? (it seems blocking all CI runs e.g. on master)

[symat]

I re-triggered the failing CI runs (there was also a failure in C-client tests, but I think I saw that particular error before and it is an unrelated flaky)

[eolivelli]

@symat I think that we should merge this an then follow up on the flaky test.

@ztzg maybe you could also help here ?

[symat]

I agree, the patch is already helping - at least the C client can be compiled now :)
Merging it now to all active branches (even to branch-3.6, in case if we will need an other RC)