ZOOKEEPER-4794: Reduce the ZKDatabase#committedLog memory usage. #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Jan 25, 2024
| public byte[] getSerializeData() { | ||
| if (this.hdr == null) { | ||
| return null; | ||
| } | ||
|
|
||
| if (this.serializeData == null) { |
There was a problem hiding this comment.
so basically you are saying that caching this value is useless ?
do you know why we were caching it ?
There was a problem hiding this comment.
See #2030, the aim is to reduce the serialization. From the prd, the memory looks more sensitive.
eolivelli
approved these changes
Jan 25, 2024
hangc0276
approved these changes
Jan 26, 2024
anmolnar
approved these changes
Feb 9, 2024
| // This is the only place that can throw IO exception | ||
| hasNext = itr.next(); | ||
|
|
||
| } catch (IOException e) { | ||
| LOG.error("Unable to read txnlog from disk", e); | ||
| hasNext = false; | ||
| p = new Proposal(); |
There was a problem hiding this comment.
Weird to create objects in catch block, but it's okay.
|
Merged to |
horizonzy |
Thanks, now you're officially a ZooKeeper contributor. ;) |
AlphaCanisMajoris
pushed a commit
to AlphaCanisMajoris/zookeeper
that referenced
this pull request
Mar 28, 2024
Reduce the committed log memory usage. Fix ci. Reviewers: eolivelli, hangc0276, anmolnar Author: horizonzy Closes apache#2115 from horizonzy/reduce-committed-log-memory-usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases, the committed log isn't used, it's only used in the fast follower synchronization.
So we can generate the QuorumPacket when fast follower synchronizing to reduce the ZKDatabase#committedLog memory usage.