ZOOKEEPER-4810: Fix buf data race at format_endpoint_info() #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format_endpoint_info() is widely called in the IO thread. And the some ZOOAPIs will call this method too: zoo_cycle_next_server() and zoo_get_current_server(). These APIs return the same static buffer read/write by IO thread causes data race.
fanyang89
force-pushed
the
fix-c-client-format-endpoint-race
branch
from
f938c5d
to
2357e16
Compare
kezhuw
reviewed
Aug 26, 2024
| @@ -5111,11 +5111,11 @@ int zoo_add_auth(zhandle_t *zh,const char* scheme,const char* cert, | |||
|
|
|||
| static const char* format_endpoint_info(const struct sockaddr_storage* ep) | |||
| { | |||
| static char buf[134] = { 0 }; | |||
| static __thread char buf[134] = { 0 }; | |||
There was a problem hiding this comment.
Do we need a macro here to accommodate single thread version and different compilers ?
cc @ztzg
There was a problem hiding this comment.
__thread will do nothing in st mode, generating the same asm as without it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_endpoint_info() is widely called in the IO thread. And the some ZOOAPIs will call this method too: zoo_cycle_next_server() and zoo_get_current_server(). These APIs return the same static buffer read/write by IO thread causes data race.