New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer` in JMX module #294

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@asdf2014
Member

asdf2014 commented Jun 27, 2017

The wrong ObjectName about MBeanServer in JMX module, should log4j:hierarchy=default rather than log4j:hiearchy=default.

@asdf2014 asdf2014 force-pushed the asdf2014:ZOOKEEPER-2822 branch from 8654cc0 to 39e1275 Nov 18, 2018

@asdf2014 asdf2014 force-pushed the asdf2014:ZOOKEEPER-2822 branch from 39e1275 to 82da83a Nov 18, 2018

@asdf2014 asdf2014 closed this Nov 18, 2018

@asdf2014 asdf2014 reopened this Nov 18, 2018

@eolivelli

This comment has been minimized.

This maybe getConstructor() instead of getDeclaredConstructor()

This comment has been minimized.

Member

asdf2014 replied Nov 18, 2018

Thanks. I will fix it.

@eolivelli

eolivelli suggested changes Nov 18, 2018 edited

Thank you @asdf2014

I left a comment.

Please also @hanm @anmolnar take a look

@@ -71,7 +71,7 @@ public static void registerLog4jMBeans() throws JMException {
// org.apache.log4j.jmx.HierarchyDynamicMBean hdm = new org.apache.log4j.jmx.HierarchyDynamicMBean();
Object hdm = Class.forName("org.apache.log4j.jmx.HierarchyDynamicMBean").getDeclaredConstructor().newInstance();

ObjectName mbo = new ObjectName("log4j:hiearchy=default");
ObjectName mbo = new ObjectName("log4j:hierarchy=default");

This comment has been minimized.

@eolivelli

eolivelli Nov 18, 2018

Contributor

Is change may have an impact on integrated systems.
Maybe we could make this name configurable so that people will be able to revert the name.
This change can be only in master (3.6.0) as it is a public configuration/API change

This comment has been minimized.

@asdf2014

asdf2014 Nov 18, 2018

Member

Hi, @eolivelli . Thanks for your reviewing. Indeed, turning it into a configurable one would be very helpful in upgrading an integrated system. So, let's be clear, should we add a new JVM option or add a new environment variable to the operating system?

@eolivelli

This comment has been minimized.

Contributor

eolivelli commented Nov 18, 2018

I would go for a system property

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Nov 19, 2018

@eolivelli Yep, I agree with you.


ObjectName mbo = new ObjectName("log4j:hiearchy=default");
String mbean = System.getenv("zookeeper.jmx.log4j.mbean");

This comment has been minimized.

@eolivelli

eolivelli Nov 20, 2018

Contributor

You should use System.getProperty(name,defaultvalue)

This comment has been minimized.

@asdf2014

asdf2014 Nov 20, 2018

Member

I would go for a system property

FYI, System.getenv() is for Operating System environment variables, whereas System.getProperty() is for JVM arguments which are passed as -DpropName=value to Java application launcher.

So, maybe use getenv() would be more reasonable.

This comment has been minimized.

@eolivelli

eolivelli Nov 20, 2018

Contributor

As far as I know in ZK it is common to use System Properties and not environment variables.

I think that the launcher for the server process is setting as system property every configuration parameter.

Do you have any example of usages of getEnv in ZooKeeper ?

This comment has been minimized.

@asdf2014

asdf2014 Nov 20, 2018

Member

@eolivelli Okay, I will modify it.

@eolivelli

This comment has been minimized.

Contributor

eolivelli commented Nov 20, 2018

We should also add the property to the docs

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Nov 20, 2018

@eolivelli Thanks for your comment. I will describe this variable in zookeeperJMX.md.

@anmolnar

Nice catch @asdf2014 ! Thanks for providing the patch.
I support the idea of making it configurable and for that please use System.getProperty(), it's standard across ZooKeeper.

@asdf2014 asdf2014 force-pushed the asdf2014:ZOOKEEPER-2822 branch from 98a5392 to 294cf53 Nov 21, 2018

@anmolnar

+1

@eolivelli

+1
awesome work @asdf2014

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Nov 22, 2018

@eolivelli @anmolnar Thanks for your approval.

@anmolnar

This comment has been minimized.

Contributor

anmolnar commented Nov 22, 2018

retest this please

1 similar comment
@anmolnar

This comment has been minimized.

Contributor

anmolnar commented Nov 23, 2018

retest this please

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Nov 27, 2018

Hi, @anmolnar @eolivelli . Is there anything I need to do before we merge this PR?

@eolivelli

This comment has been minimized.

Contributor

eolivelli commented Nov 27, 2018

@anmolnar green lights from CI

This is a trivial patch, do you need another committer ?

@asfgit asfgit closed this in 91c6cb2 Nov 27, 2018

asfgit pushed a commit that referenced this pull request Nov 27, 2018

ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer` in JMX module
The wrong `ObjectName` about `MBeanServer` in JMX module, should `log4j:hierarchy=default` rather than `log4j:hiearchy=default`.

Author: asdf2014 <benedictjin2016@gmail.com>

Reviewers: andor@apache.org

Closes #294 from asdf2014/ZOOKEEPER-2822 and squashes the following commits:

294cf53 [asdf2014] Using `System.getProperty` instead of `System.getenv` & doc this change
ed756a9 [asdf2014] Add `zookeeper.jmx.log4j.mbean`
82da83a [asdf2014] ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer` in JMX module

(cherry picked from commit 91c6cb2)
Signed-off-by: Andor Molnar <andor@apache.org>
@anmolnar

This comment has been minimized.

Contributor

anmolnar commented Nov 27, 2018

Committed to master and 3.5 branches. Thanks @asdf2014 !

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Nov 27, 2018

You are welcome.

@asdf2014 asdf2014 deleted the asdf2014:ZOOKEEPER-2822 branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment