Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/rawbuffer eq #7

Merged
merged 3 commits into from
Dec 10, 2015
Merged

Fix/rawbuffer eq #7

merged 3 commits into from
Dec 10, 2015

Conversation

savuor
Copy link
Collaborator

@savuor savuor commented Dec 9, 2015

Fixes issue #6

@savuor savuor mentioned this pull request Dec 9, 2015
Closed
@apavlenko apavlenko self-assigned this Dec 10, 2015
@apavlenko
Copy link
Owner

The fix looks good, but the bug existence means absence of test for this method - @savuor, could you also add a test?

@apavlenko apavlenko assigned savuor and unassigned apavlenko Dec 10, 2015
@savuor
Copy link
Collaborator Author

savuor commented Dec 10, 2015

test added

@apavlenko apavlenko assigned apavlenko and unassigned savuor Dec 10, 2015
@apavlenko
Copy link
Owner

👍 cool!

apavlenko added a commit that referenced this pull request Dec 10, 2015
@apavlenko
Merge pull request #7 from apavlenko/fix/rawbuffer_eq
45e09cf 
Fix/rawbuffer eq
@apavlenko apavlenko merged commit 45e09cf into master Dec 10, 2015
@apavlenko apavlenko deleted the fix/rawbuffer_eq branch December 28, 2015 10:28
@apavlenko apavlenko added this to the Milestone 1 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@apavlenko apavlenko

Labels
PR-fix
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging this pull request may close these issues.
2 participants
@savuor @apavlenko