Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model extension #317

Merged
merged 24 commits into from
Aug 9, 2024
Merged

Model extension #317

merged 24 commits into from
Aug 9, 2024

Conversation

M-R-Schaefer
Copy link
Contributor

No description provided.

M-R-Schaefer and others added 19 commits August 6, 2024 21:03
@M-R-Schaefer
sketch of multi model api
a1d419a
@M-R-Schaefer
renamed import path, slimmed down model config, finalized e3x basis u…
cd44634 
…sage
@M-R-Schaefer
included dtype casting in equivmp
5b95cdd
@M-R-Schaefer
renamed submodule
9be93e5
@M-R-Schaefer
forgot to add file
01c21f6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c31416d 
for more information, see https://pre-commit.ci
@M-R-Schaefer
only representation
b863690
@M-R-Schaefer
moved model configs to separate module
e1b5513
@M-R-Schaefer
added so3krates representation
cf40a76
@M-R-Schaefer
Merge branch 'model-extension' of https://github.com/apax-hub/apax in…
436eb88 
…to model-extension
@M-R-Schaefer
updated config
e8579a6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
62bec5e 
for more information, see https://pre-commit.ci
@M-R-Schaefer
Merge branch 'model-extension' of https://github.com/apax-hub/apax in…
7e67a4d 
…to model-extension
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c0c9740 
for more information, see https://pre-commit.ci
@M-R-Schaefer
update tests
03ea04f
@M-R-Schaefer
Merge branch 'model-extension' of https://github.com/apax-hub/apax in…
b38fabb 
…to model-extension
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ce9a1df 
for more information, see https://pre-commit.ci
@M-R-Schaefer
Merge branch 'main' into model-extension
05517f2
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d22dd8c 
for more information, see https://pre-commit.ci
@M-R-Schaefer
Copy link
Contributor Author

pre-commit.ci autofix

@M-R-Schaefer M-R-Schaefer marked this pull request as ready for review August 8, 2024 13:42
Tetracarbonylnickel
Tetracarbonylnickel approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@Tetracarbonylnickel Tetracarbonylnickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and surprisingly smooth!

@M-R-Schaefer
Copy link
Contributor Author

pre-commit.ci autofix

@M-R-Schaefer M-R-Schaefer merged commit 677288d into main Aug 9, 2024
2 checks passed
@M-R-Schaefer M-R-Schaefer deleted the model-extension branch August 9, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tetracarbonylnickel Tetracarbonylnickel Tetracarbonylnickel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-R-Schaefer @Tetracarbonylnickel