Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support nebulagraph #3716

Merged
merged 1 commit into from
Jun 25, 2023
Merged

feat: support nebulagraph #3716

merged 1 commit into from
Jun 25, 2023

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Jun 11, 2023 •
edited
Loading

close #3835

Contents of this PR

  • Added deploy/nebula & deploy/nebula-cluster containing necessary cluster definitions, configs, scripts for Nebula Graph.
  • Able to create NebulaGraph clusters with the following steps:
  1. install nebula and nebula-cluster
helm install nebula ./deploy/nebula
helm install nebula-cluster ./deploy/nebula-cluster
  1. port-forward svc to localhost
kubectl port-forward svc/nebula-cluster-nebula-graphd 9669:9669
  1. connect to graphd using nebula-console
 ./nebula-console --addr 127.0.0.1 --port 9669 -u root -p nebula

and add storaged hosts

ADD HOSTS "nebula-cluster-nebula-storaged-0.nebula-cluster-nebula-storaged-headless.default.svc.cluster.local":9779
ADD HOSTS "nebula-cluster-nebula-storaged-1.nebula-cluster-nebula-storaged-headless.default.svc.cluster.local":9779
ADD HOSTS "nebula-cluster-nebula-storaged-2.nebula-cluster-nebula-storaged-headless.default.svc.cluster.local":9779

Contributors

@shanshanying @xtcyclist

@JashBook JashBook added the size/XXL Denotes a PR that changes 1000+ lines. label Jun 12, 2023
@xtcyclist xtcyclist force-pushed the feature/support_nebulagraph branch from fb07899 to d748d1f Compare June 15, 2023 03:47
@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines. size/XXL Denotes a PR that changes 1000+ lines. and removed size/XXL Denotes a PR that changes 1000+ lines. size/XL Denotes a PR that changes 500-999 lines. labels Jun 15, 2023
@xtcyclist xtcyclist marked this pull request as ready for review June 16, 2023 09:05
nashtsai
nashtsai reviewed Jun 19, 2023
View reviewed changes
deploy/nebula/templates/clusterdefinition.yaml
port: "$(SVC_PORT_tcp-nebula)"
accesskey: ""
secretkey: ""
componentDefs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following components missing telemetry configs?

Copy link
Contributor Author

@xtcyclist xtcyclist Jun 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefered to support monitoring-related functions in future PRs. Added an issue here: #3863. We actually have many more utility modules that could be added. This PR provides a minimum set.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remember to add connect(a DAPR binding is needed), backup & restore(in tools) in near future

nashtsai
nashtsai reviewed Jun 19, 2023
View reviewed changes
deploy/nebula/values.yaml Outdated Show resolved Hide resolved
@xtcyclist xtcyclist force-pushed the feature/support_nebulagraph branch from b1644b4 to eefea6d Compare June 19, 2023 11:24
@shanshanying
Copy link
Contributor

@nashtsai PTAL

nashtsai
nashtsai reviewed Jun 20, 2023
View reviewed changes
deploy/nebula/Chart.yaml Outdated Show resolved Hide resolved
@xtcyclist @shanshanying
Support NebulaGraph.
cd8b3fe 
Co-authored-by: Shanshan.Ying <shanshan.ying@apecloud.com>
Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>
@xtcyclist xtcyclist force-pushed the feature/support_nebulagraph branch from c91b9fe to cd8b3fe Compare June 21, 2023 08:15
@xtcyclist xtcyclist requested a review from nashtsai June 21, 2023 08:17
@shanshanying
Copy link
Contributor

@nashtsai @ldming PTAL

@shanshanying shanshanying merged commit 92a5ca0 into apecloud:main Jun 25, 2023
ldming pushed a commit that referenced this pull request Nov 21, 2023
@xtcyclist @shanshanying @ldming
feat: support nebulagraph (#3716)
819841a 
Co-authored-by: Shanshan.Ying <shanshan.ying@apecloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayutah nayutah nayutah approved these changes

@wangyelei wangyelei wangyelei approved these changes

@nashtsai nashtsai nashtsai approved these changes

@realzyy realzyy Awaiting requested review from realzyy

@ldming ldming Awaiting requested review from ldming

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@dengshaojiang dengshaojiang Awaiting requested review from dengshaojiang

@leon-inf leon-inf Awaiting requested review from leon-inf

Assignees
No one assigned
Labels
area/user-interaction feature size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Features] Support NebulaGraph
7 participants
@xtcyclist @shanshanying @nashtsai @wangyelei @nayutah @JashBook @apecloud-bot