chore: add the region field to the minio StorageProvider #7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjx20
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
weicao
reviewed
Jul 29, 2024
| @@ -258,8 +258,12 @@ spec: | |||
| provisioner: ru.yandex.s3.csi | |||
| parameters: | |||
| mounter: geesefs | |||
| {{ `{{ $regionOption := "" }}` }} | |||
There was a problem hiding this comment.
Do other object storage StorageProvider CRs need the region option? e.g. gcs-s3comp.
There was a problem hiding this comment.
I confirmed that the region option is not necessary for other storage. For GCS, it seems that requests would be routed to the correct region automatically. And for other storage services, the endpoint URL would contain the region info.
weicao
approved these changes
Jul 29, 2024
ldming
approved these changes
Jul 29, 2024
|
/cherry-pick release-0.9 |
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
(cherry picked from commit 390b4a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.