Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix summariser time CpuCount warnings for cloud accounting #156

Merged
merged 4 commits into from
Apr 5, 2018
Merged

Fix summariser time CpuCount warnings for cloud accounting #156

merged 4 commits into from
Apr 5, 2018

Commits on Apr 5, 2018

  1. Add a test for incomplete cloud messages received 

    - the test captures what happens as of 1.6.1 and
  helps convince us we aren't breaking anything
  when making any future chnages to default
  CloudRecord values.
    @gregcorbett @tofu-rocketry
    gregcorbett authored and tofu-rocketry committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    baacdf4 View commit details
    Browse the repository at this point in the history

  2. Add a test for Cloud records with missing fields 

    - Helps convince us we aren't breaking anything
  when making any future changes to default
  CloudRecord values
    @gregcorbett @tofu-rocketry
    gregcorbett authored and tofu-rocketry committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    4739c1d View commit details
    Browse the repository at this point in the history

  3. Set a default for CpuCount in cloud records 

    - when it is ommited, NULL is written as the CpuCount in the CloudRecord
  table, which causes problems at summariser time as
  NULL CpuCounts aren't allowed in the CloudSummaries table
    @gregcorbett @tofu-rocketry
    gregcorbett authored and tofu-rocketry committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    534303d View commit details
    Browse the repository at this point in the history

  4. Add update script to reduce summariser warnings 

    - Cleans up any existing cloud data with a NULL CpuCount,
  which causes warnings when we try and insert cloud
  summarises with NULL CpuCounts into the cloud summary table
    @gregcorbett @tofu-rocketry
    gregcorbett authored and tofu-rocketry committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    c4d8da0 View commit details
    Browse the repository at this point in the history