Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variable for c++ template: project, namespace, etc #69

Closed
wants to merge 1 commit into from

Conversation

alanqian
Copy link

@alanqian alanqian commented Apr 9, 2015

  1. generic variable added: project, namespace
  2. modified c/c++ guard for google style: PROJECT_FILE_H_
  3. add variable for unit test(gtest): testclass, testvar

1. generic variable added: project, namespace

2. modified c/c++ guard for google style: PROJECT_FILE_H_

3. add variable for unit test(gtest): testclass, testvar
@muff1nman
Copy link
Collaborator

Thank you for the pr! A couple of thoughts:

  1. We have a way to add user defined variables as implmeneted in Allow users to define custom variables to expand #58. I would rather keep the built in list of variables to a small common list. So try out Allow users to define custom variables to expand #58 and let us know if you run into any troubles.
  2. Can you separate out the modifications to the c++ guard in a separate pr?
  3. Indentation needs to be fixed.

Thanks!

@muff1nman
Copy link
Collaborator

Closing due to lack of activity

@muff1nman muff1nman closed this Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants