Skip to content

Commit

Permalink
create 1.0 version for amp-sticky-ad extension (ampproject#5923)
Browse files Browse the repository at this point in the history
* add 1.0 folder

* add test

* test fixed by Dima

* fix tests

* fix share-tracking test

added html_format: AMP @powdercloud

new line in test-amp-apester-media

validator fix #2

removed decodeUrl

validator fix: data-apester-media to data-apester-media-id

minor changes to css and loader

refactor(css): change css classes

css
  • Loading branch information
zhouyx authored and Ori Avraham committed Nov 2, 2016
1 parent 915c99c commit 76de034
Show file tree
Hide file tree
Showing 12 changed files with 1,000 additions and 268 deletions.
2 changes: 1 addition & 1 deletion examples/sticky.ads.amp.html
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@

</style>
<script async custom-element="amp-lightbox" src="https://cdn.ampproject.org/v0/amp-lightbox-0.1.js"></script>
<script async custom-element="amp-sticky-ad" src="https://cdn.ampproject.org/v0/amp-sticky-ad-0.1.js"></script>
<script async custom-element="amp-sticky-ad" src="https://cdn.ampproject.org/v0/amp-sticky-ad-1.0.js"></script>
<style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
<script async src="https://cdn.ampproject.org/v0.js"></script>
<script async src="./viewer-integr.js" data-amp-report-test="viewer-integr.js"></script>
Expand Down
4 changes: 2 additions & 2 deletions extensions/amp-apester-media/0.1/amp-apester-media.css
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
opacity: 1 !important;
}

.amp-apester-loader {
.amp-apester-loader amp-img {
height: 100px;
width: 100px;
top: 50%;
Expand All @@ -34,7 +34,7 @@
margin-top: -22px;
}

.amp-apester-loader-container {
.amp-apester-loader {
background-color: white;
}

Expand Down
4 changes: 1 addition & 3 deletions extensions/amp-share-tracking/0.1/amp-share-tracking.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,4 @@ export class AmpShareTracking extends AMP.BaseElement {


// Install the extension.
AMP.extension('amp-share-tracking', AMP => {
AMP.registerElement('amp-share-tracking', AmpShareTracking);
});
AMP.registerElement('amp-share-tracking', AmpShareTracking);
4 changes: 3 additions & 1 deletion extensions/amp-sticky-ad/0.1/amp-sticky-ad.js
Original file line number Diff line number Diff line change
Expand Up @@ -238,4 +238,6 @@ class AmpStickyAd extends AMP.BaseElement {
}
}

AMP.registerElement('amp-sticky-ad', AmpStickyAd, CSS);
AMP.extension('amp-sticky-ad', AMP => {
AMP.registerElement('amp-sticky-ad', AmpStickyAd, CSS);
});

0 comments on commit 76de034

Please sign in to comment.