Feat/hermes 4387/companion display and video #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4039) * Add a story experiment ID to the performance service. * Use ampdocService instead of getAmpdoc.
* Enable the macro-after-long-task experiment as url and normal experiment in canary and production * Do not enable the experiment to 100% of production traffic.
* skip failing tests * nit
…y. (ampproject#23778)" (ampproject#24127) This reverts commit 362166f.
…en body. (ampproject#24135) * Revert "Revert "Relatively drastically improve FCP for docs with a hidden body. (ampproject#23778)" (ampproject#24127)" This reverts commit b6a200f. * Fix tests broken by overlapping commits
* Add audio support to amp-access-scroll extension Add junoatscroll to owners * Use Vsync.mutate in render * Install styles in extension constructor * Message can be null * Fix closure types in scroll-component * REVIEW -> OK
…oject#24058) * Enable experiment opt-in using inbox envelope URL query params. * turn on inabox-viewport-friendly by default * refactor * nit * clean up * Fix tests failures caused by the URL change in the envelope
* move localization * fix dep check * lazy init
* move config * comments * lint * more lint * fix bad auto import * naming
* Toggle experiments correctly for inabox e2e tests * don't set exp= when no experiments. * small improvement.
… presence on parents elements on amp-accordion (ampproject#24142) * Set a destination scope to hasAction method to prevent checking tap presence on parents elements on amp-accordion * Fixes type check
* separate binding * reduce diff * fix * Add feature flag.
* Adds a fixed layout check * Recycled PR to add isLayoutSizeFixed
…ect#24136) * Nit visual changes to the chrome extension * Requested changes
* New analytics trigger event in amp-audio.js * Created test page * Analytics trigger event in play/pause action * Unit test for audio-play/audio-pause analytics event * Document the analytics support in amp-audio.md * Fix failed type-check * Removes analytics trigger in play() and pause() call * Changes audio-play analytics event listener from playing event to play event * Removes audio play/pause analytics event unit test * Removes analyticsEvent_ private method and inlines triggerAnalyticsEvent function * Updates amp-audio.md Updates that audio-play and audio-pause are the two analytics events supported now * Fixes prettier errors
* Prefix remaining globals in src. * Fix lint.
* added src info for emails * Update amp-img.md * Update amp-anim.md
* cl/269636175 Revision bump for ampproject#24473 * fix reverse sync
* Added missing URL to 'Analytics Vendors' link * Updated links to Analytics vendors 'Analytics Vendors' links now reference the vendor table in the doc instead of just the page.
* Better amp-script docs. * Use new shortcodes. * Fix typo.
* backup experiment constant list * lint & clean list
* AmpStoryEventTracker and tests * types * reviews * add unit tests * increasing timeout in integration tests hoping to pass travis * reviews * hoping this fixes travis tests * increase test waitForElementLayout timeout * fix presubmit * skip offending browsers * add comment for sandbox story events
golovatuy
pushed a commit
that referenced
this pull request
Aug 11, 2021
…mpproject#35023) * Add runtime service to handle execute tasks like adding ports to the network. - Add entry points to wrapper such as creating PortOperator and adding ports. - Update compile script since it can perform as normal Closure compiler. * Fix lint errors. * Remove externs.js since the compiled code with it would keep 'goog' hence violate JSC_CANNOT_HAVE_MODULE_VAR_NAMED_GOOG. * Construct channel with FrameService iframe and add it to the network. - Add DeferredChannel to the network first and resolve it after the real channel is constructed. - Ensure FrameService port is always added before any widget initialization * Report available widgets to FrameService so that it can request widget ports to listen on. - Add protocol buffer library to generate FrameService protocol - Report widget by sending messages to FrameService's RespondingChannel. - Add necessary endpoints to Closure custom API. * Move proto library to third_party folder. - Move entire proto folder to third_party folder - Update whitelist and source globs for new third_party library - Add exports file so that 'require' can be avoided in the extension * Fix source glob error. * Fix source glob error #2. * Update protoc from protobug Github repo. * Remove assistjs extension and all relevant libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions:
(chore):).ProjectX: Implement some feature).Fixes,Closes, orResolvesfollowed the issue number will automatically close the issue.Example of a good description:
Emojis for categorizing pull requests:
✨ New feature (
:sparkles:)🐛 Bug fix (
:bug:)🔥 P0 fix (
:fire:)✅ Tests (
:white_check_mark:)🚀 Performance improvements (
:rocket:)🖍 CSS / Styling (
:crayon:)♿ Accessibility (
:wheelchair:)🌐 Internationalization (
:globe_with_meridians:)📖 Documentation (
:book:)🏗 Infrastructure / Tooling / Builds / CI (
:building_construction:)⏪ Reverting a previous change (
:rewind:)♻️ Refactoring (like moving around code w/o any changes) (
:recycle:)🚮 Deleting code (
:put_litter_in_its_place:)