Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sign typed data [APE-1137] #3

Open
banteg opened this issue Jun 28, 2023 · 0 comments
Open

sign typed data [APE-1137] #3

banteg opened this issue Jun 28, 2023 · 0 comments

Comments

@banteg
Copy link

banteg commented Jun 28, 2023

depends on ApeWorX/ape#1508

when ape adds support to pass eip-712 messages for signing, it would be possible to use eth_signTypedData_v4 and display the full message in frame instead of just its hash.

ape-frame/ape_frame/accounts.py

Line 39 in c2c1545

raw_signature = self.web3.eth.sign(self.address, hexstr=_hash_eip191_message(msg).hex())

@vany365 vany365 changed the title sign typed data sign typed data [APE-1137] Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@banteg