Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stage path to request path if api gateway host #8

Closed
wants to merge 1 commit into from

Conversation

dabio
Copy link

@dabio dabio commented Feb 15, 2018

url: https://1234567890.execute-api.us-east-1.amazonaws.com/prod/pets
expected path: /prod/pets
actual path: /pets

This will add the stage path part to the request url path if the host is an aws api gateway host.

This will add the stage path part to the request url path if the
host is a aws api gateway.
@tj
Copy link
Member

tj commented Feb 17, 2018

Hmm I think /pets is a bit more desirable since the app doesn't have to be stage-aware, and the stage can be grabbed from an env var or X-Stage

@dabio
Copy link
Author

dabio commented Mar 22, 2018

Okay.

@dabio dabio closed this Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants