Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on all supported versions of go #91

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Conversation

abenerd
Copy link
Contributor

@abenerd abenerd commented Aug 18, 2020

This PR allows us to test on all versions of go that the library supports and updates the used action versions so the already fast tests run even faster.

Update workflows to latest versions
@abenerd
Copy link
Contributor Author

abenerd commented Aug 18, 2020

We should think about upping the go version to 1.13 not only because of the failing test but also because go officially only supports the latest and the two preceding versions which with the release of 1.15 would be 1.13.

@tj
Copy link
Member

tj commented Aug 18, 2020

SGTM! I didn't realize it's a new-ish method, seems fair to remove 1.12

@tj tj merged commit 8da8315 into apex:master Aug 18, 2020
@tj
Copy link
Member

tj commented Aug 18, 2020

thanks!

@abenerd abenerd deleted the feature/github-actions branch August 18, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants