Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSRV? #6

Closed
0323pin opened this issue Jan 5, 2023 · 5 comments · Fixed by #8
Closed

MSRV? #6

0323pin opened this issue Jan 5, 2023 · 5 comments · Fixed by #8

Comments

@0323pin
Copy link
Contributor

0323pin commented Jan 5, 2023 •
edited
Loading

Hi,

I've just packaged jolly for NetBSD, it works great locally on my machine.
A future wish, if you don't mind. It would be nice to be able to customize the background, foreground and highlight colors of the application :)

In order to merge the package, I need to ask you one thing.
NetBSD currently has Rust-1.64 as default. I'm running Rust-1.66 on my machine and have already been asked to revert a few package updates because they don't build with 1.64. So, what's the minimum required version to build jolly?

I've assigned myself as package maintainer so, I'll keep it up-to-date ;)
Regards and thank you for this tool.
@apgoetz apgoetz mentioned this issue Jan 6, 2023
Closed
@apgoetz
Copy link
Owner

apgoetz commented Jan 6, 2023

Thanks for the feedback. I have added theming support as a feature request in #7

Regarding MSRV, jolly depends on iced for its gui toolkit, and while MSRV is not explicitly mentioned by name by iced, it is pretty clear that the only supported rustc is latest stable. iced 0.6.0 is already using GATs which were only stabilized in rust 1.65.

I will add a note to readme describing MSRV, but unfortunately I don't think that will solve the NetBSD problems.

apgoetz added a commit that referenced this issue Jan 6, 2023
@apgoetz
Added MSRV value to crate
002956a 
Jolly will track latest stable like its major `iced` dependency.

This is now mentioned in the README as well as `Cargo.toml`.

CI has also been updated to run tests on MSRV instead of whatever
version of rust github happens to have installed on its runners.

Fixes #6
apgoetz added a commit that referenced this issue Jan 6, 2023
@apgoetz
Added MSRV value to crate
6048728 
Jolly will track latest stable like its major `iced` dependency.

This is now mentioned in the README as well as `Cargo.toml`.

CI has also been updated to run tests on MSRV instead of whatever
version of rust github happens to have installed on its runners.

Fixes #6
@apgoetz apgoetz mentioned this issue Jan 6, 2023
Merged
@apgoetz apgoetz closed this as completed in #8 Jan 6, 2023
apgoetz added a commit that referenced this issue Jan 6, 2023
@apgoetz
Added MSRV value to crate (#8)
1c32ef8 
Jolly will track latest stable like its major `iced` dependency.

This is now mentioned in the README as well as `Cargo.toml`.

CI has also been updated to run tests on MSRV instead of whatever
version of rust github happens to have installed on its runners.

Fixes #6
@0323pin
Copy link
Contributor Author

0323pin commented Jan 6, 2023

@apgoetz Thanks!

I will add a note to readme describing MSRV, but unfortunately I don't think that will solve the NetBSD problems.

No problem, we are not stucked with 1.64 😄
I was expecting 1.66 to be merged this week but, for some reason it has been delayed.
I'll merge jolly as soon it lands. For now, I'm keeping it on my own repository.

Will post you a note when it's done. If you would like, I can also do a PR adding install instructions to the README.MD

@apgoetz
Copy link
Owner

apgoetz commented Jan 6, 2023

OK, glad to hear you will get it merged.

Feel free to open a PR on the README when you are ready. I think it would be hilarious if the only OS with detailed installation instructions is NetBSD.

@0323pin
Copy link
Contributor Author

0323pin commented Jan 6, 2023

Please feel free to comment if you have anything you would like to change, https://codeberg.org/pin/netbsd/src/branch/master/Packages/jolly

@0323pin
Copy link
Contributor Author

0323pin commented Jan 23, 2023 •
edited
Loading

@apgoetz It took longer than expected but, merged today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added MSRV value to crate apgoetz/jolly
2 participants
@apgoetz @0323pin