Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to fit_peaks() support for additional methods #29

Open
aphalo opened this issue Mar 30, 2024 · 1 comment
Open

Add to fit_peaks() support for additional methods #29

aphalo opened this issue Mar 30, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@aphalo
Copy link
Owner

aphalo commented Mar 30, 2024

Currently the only method supported is spline, which is usually o.k. for estimating the wavelength location but not the height of a peak. Fitting Gauss, Lorentz and Voigt functions could be implemented as these are frequently used, at least when peaks are on a low baseline

See files in folder inst-not for background information. These would need to use nls() and some kind of self starting functions.

See also function fit_peaks() in package 'chromatographR'.

@aphalo aphalo added the enhancement New feature or request label Mar 30, 2024
@aphalo aphalo self-assigned this Mar 30, 2024
@aphalo aphalo added this to the 0.11.2 milestone Mar 30, 2024
@aphalo
Copy link
Owner Author

aphalo commented Mar 30, 2024

Examples from Alan Morison

thumbnail_image001

thumbnail_image002

thumbnail_image003

@aphalo aphalo modified the milestones: 0.11.2, 0.11.3 Mar 31, 2024
@aphalo aphalo modified the milestones: 0.11.3, 0.11.4 Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant