Phenotyping #38
Phenotyping #38
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 91.89% 83.44% -8.45%
==========================================
Files 67 80 +13
Lines 2146 2416 +270
==========================================
+ Hits 1972 2016 +44
- Misses 174 400 +226
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Hi @Thomzoy, could you please chunk this PR into smaller ones? A PR should only address a specific issue or feature at the time. |
eds_scikit/io/base.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| from box import Box | |||
There was a problem hiding this comment.
Could we avoid adding yet another dependency for a feature this simple?
| self._features[feature_name] = feature | ||
| self.last_feature = feature_name | ||
|
|
||
| def last(self): |
There was a problem hiding this comment.
We should at least document this since this is a very weird behaviour in general
| df["phenotype"] = self.name | ||
| df = df.rename(columns={"concept": "subphenotype"}) | ||
|
|
||
| bd.cache(df) |
There was a problem hiding this comment.
Let's bring bd.cache() into from_code_func directly?
eds_scikit/phenotype/base.py
Outdated
| ) | ||
| return self | ||
|
|
||
| def get(self, **kwargs): |
There was a problem hiding this comment.
Maybe get_results would be a bit more explicit?
Description
Checklist