Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Completeness greater than one (Specific variable are not dropped when needed) #31

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix: Completeness greater than one (Specific variable are not dropped when needed) #31

merged 4 commits into from
Oct 16, 2023

Conversation

Aremaki
Copy link
Collaborator

@Aremaki Aremaki commented Sep 29, 2023

Completeness greater than one

Description

Need to remove column from a drop duplicate when it is not used

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@Aremaki Aremaki linked an issue Sep 29, 2023 that may be closed by this pull request
C > 1 for note #30
Closed
svittoz
svittoz approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@svittoz svittoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !

@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...robes/biology/completeness_predictors/per_visit.py 100.00% <100.00%> (ø)
...bes/condition/completeness_predictors/per_visit.py 100.00% <100.00%> (ø)
...a/probes/note/completeness_predictors/per_visit.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@svittoz svittoz merged commit 6a07a30 into main Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svittoz svittoz svittoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C > 1 for note
2 participants
@Aremaki @svittoz