New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wins losses on player #16

Open

straydogstudio wants to merge 1 commit into api-first:master from straydogstudio:master

straydogstudio commented Sep 17, 2015

What this does:

Adds wins / losses to the player model
Adds one convenience method for percentage of wins

Discussion items:

The user should not be able to update their wins or losses. How should this be implemented and tested in Pundit?
Where in the model would this value be set?
Documentation not taken care of. What should be done for these kind of fields that are not parameters but are available on read.


          Wins losses on player

6c58cea

barelyknown deployed to blackjack-api-staging-pr-16

September 17, 2015 18:41

Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet