Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #488 Validation errors are shown as "Server communication error" #515

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

slim
Copy link
Contributor

@slim slim commented Nov 8, 2023

Q A
Branch? main
Tickets
License MIT
Doc PR

This fixes a bug which is a combination of 2 bugs in api-doc-parser library and 2 bugs in this repo.

Fix also requires PR to be merged api-platform/api-doc-parser#132

When parent function fetchJsonLd() was called with method POST is
inherited the method which resulted in a status 415 response from the
API which refused the unsafe method with unrecognized Content Type
jsonld
were complaining that ReferenceError: TextEncoder is not defined
@slim
Copy link
Contributor Author

slim commented Nov 20, 2023

I fixed the tests, but now CI has linter cosmetic complaints (automatically fixable) that I don't get locally when I do yarn lint. So I can't fix those.

@alanpoulain alanpoulain merged commit eebbc51 into api-platform:main Nov 27, 2023
1 check passed
@alanpoulain
Copy link
Member

Thanks @slim!

PawelSuwinski pushed a commit to PawelSuwinski/admin that referenced this pull request Feb 15, 2024
…-platform#515)

* fix: documentLoader() was not loading with method GET

When parent function fetchJsonLd() was called with method POST the method is inherited which resulted in a status 415 response from the API which refused the unsafe method with unrecognized Content Type jsonld.

* fix: was not displaying a useful error message when creating an entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants