-
-
Notifications
You must be signed in to change notification settings - Fork 928
Global resource defaults implementation #3151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Oct 4, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
alanpoulain
reviewed
Oct 4, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
alanpoulain
reviewed
Oct 4, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
alanpoulain
reviewed
Oct 4, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
alanpoulain
reviewed
Oct 4, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
alanpoulain
reviewed
Oct 4, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
alanpoulain
reviewed
Oct 4, 2019
src/Metadata/Resource/Factory/AnnotationResourceMetadataFactory.php
Outdated
Show resolved
Hide resolved
soyuka
requested changes
Oct 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we add a DefaultMetadataFactory that is called prior to extractor/annotation that sets defaults based on the injected defaults?
#3135 (comment)
I'm not fond of the transformations done in the Extension.
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
soyuka
approved these changes
Oct 7, 2019
dunglas
requested changes
Oct 7, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
dunglas
approved these changes
Oct 14, 2019
Thanks @bpolaszek! |
warslett
pushed a commit
to BiffBangPow/core
that referenced
this pull request
Oct 18, 2019
* Add defaults configuration * Suggest defaults in configuration * Apply changes from code review * Add deprecation notices for legacy defaults * Apply @dunglas' suggestions
3 tasks
norkunas
pushed a commit
to norkunas/core
that referenced
this pull request
Dec 2, 2019
* Add defaults configuration * Suggest defaults in configuration * Apply changes from code review * Add deprecation notices for legacy defaults * Apply @dunglas' suggestions
This was referenced Apr 21, 2020
This was referenced Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
defaults
configuration as a new implementation of #3099 (#3135 was dropped).This one doesn't rely on a low-priority
DefaultsResourceMetadataFactory
as suggested first (because low priority means late access to some normalization logic) and implements the defaults pattern inAnnotationResourceMetadataFactory
andExtractorResourceMetadataFactory
, making configuration more consistent, which means support for short-hand config like this:Default configuration is now flattened at the bundle configuration level, removing the
attributes
sublevel to improve DX and normalizing all keys to snake_case to follow Symfony standards (both camelCase and snake_case are actually supported to be less error-prone, attributes being mostly documented as annotations):