Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the base exception extend throwable #3217

Merged
merged 1 commit into from Oct 28, 2019
Merged

Make the base exception extend throwable #3217

merged 1 commit into from Oct 28, 2019

Conversation

BackEndTea
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tickets N/a
License MIT
Doc PR N/a

This makes it more clear this interface can be 'caught'

@BackEndTea
Make the base exception extend throwable
8e21ef2 
This makes it more clear this interface can be 'caught'
dunglas
dunglas approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

@dunglas dunglas merged commit 449842a into api-platform:master Oct 28, 2019
@dunglas
Copy link
Member

dunglas commented Oct 28, 2019

Thanks!

@BackEndTea
Copy link
Contributor Author

Thank you

@BackEndTea BackEndTea deleted the patch-1 branch October 29, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BackEndTea @dunglas