[GraphQL] add support for Symfony Serializer's @SerializedName metadata
#3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Mar 29, 2020
| @@ -61,4 +69,24 @@ public function supportsNormalization($data, $format = null): bool | |||
| { | |||
| return $data instanceof Error && $data->getPrevious() instanceof ValidationException; | |||
| } | |||
|
|
|||
| private function normalizeValidationException(ValidationException $exception): string | |||
There was a problem hiding this comment.
IMO this code is too specific and should be reverted.
|
Thanks. Could you add a Behat test to make sure it works as expected? |
This reverts commit 51bc4ba.
dunglas
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by https://github.com/api-platform/core/blob/master/src/JsonSchema/SchemaFactory.php#L141
but idk if it's good idea pass 3rd and 4th argument too