Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load remaining commands #3798

Merged
merged 1 commit into from Oct 28, 2020
Merged

Lazy load remaining commands #3798

merged 1 commit into from Oct 28, 2020

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Oct 28, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tickets n/c
License MIT
Doc PR n/c

Some commands are already lazy loaded, but when profiling a command execution using Blackfire, I found this.

@dunglas dunglas merged commit 51310fd into api-platform:master Oct 28, 2020
@dunglas
Copy link
Member

dunglas commented Oct 28, 2020

Good catch! Thanks.

@deguif deguif deleted the lazy-load-command branch October 29, 2020 06:30
@deguif
Copy link
Contributor Author

deguif commented Oct 29, 2020

@dunglas do you think this can be backported to 2.5?

@dunglas
Copy link
Member

dunglas commented Oct 29, 2020

It could yes!

@deguif deguif mentioned this pull request Oct 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykiwi mykiwi mykiwi approved these changes

@fbaudry fbaudry fbaudry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deguif @dunglas @mykiwi @fbaudry