fix(openapi): do not use jsonld schema for all media types #4247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilliamxavier
commented
Apr 26, 2021
Comment on lines
+197
to
+207
| And the JSON node "paths./dummies.get.responses.200.content.application/json" should be equal to: | ||
| """ | ||
| { | ||
| "schema": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/components/schemas/Dummy" | ||
| } | ||
| } | ||
| } | ||
| """ |
There was a problem hiding this comment.
This step was failing (the schema was the same as jsonld above)
src/JsonSchema/SchemaFactory.php
Outdated
| $schema = $schema ?? new Schema(); | ||
| $schema = null !== $schema ? clone $schema : new Schema(); |
There was a problem hiding this comment.
This is the fix
There was a problem hiding this comment.
$schema ? clone $schema : new Schema() would work as well right?
There was a problem hiding this comment.
Sorry I missed this comment. Thanks for proposing a suggestion, I've just accepted it
Comment on lines
-257
to
-259
| $schema = new Schema('openapi'); | ||
| $schema->setDefinitions($schemas); | ||
|
|
There was a problem hiding this comment.
Was added by #4213, not needed anymore
| $this->jsonSchemaFactory->buildSchema($resourceClass, $format, $type, $operationType, $operationName, $schema, $serializerContext, $forceCollection); | ||
|
|
||
| return $schema; | ||
| return $this->jsonSchemaFactory->buildSchema($resourceClass, $format, $type, $operationType, $operationName, $schema, $serializerContext, $forceCollection); |
There was a problem hiding this comment.
This is a consequence of the fix
There was a problem hiding this comment.
@soyuka: Refs #4215 (comment). I have added a note to the changelog entry
This was referenced Apr 26, 2021
guilliamxavier
changed the title
guilliamxavier
changed the title
soyuka
reviewed
Apr 30, 2021
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
soyuka
reviewed
May 1, 2021
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
|
Thank you @guilliamxavier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4213