Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): fix missing array cast for RDF types in ApiResource & ApiProperty constructors #5000

Merged
merged 1 commit into from Sep 29, 2022

Conversation

chalasr
Copy link
Contributor

@chalasr chalasr commented Sep 22, 2022

Q A
Branch? 3.0
Tickets -
License MIT
Doc PR -

Makes the constructor consistent with withTypes().

@chalasr chalasr force-pushed the fix-cast-types branch 3 times, most recently from becb13e to 032cf9d Compare September 23, 2022 13:27
@chalasr chalasr changed the title fix(metadata): Fix missing array cast for RDF types in ApiResource & ApiProperty constructors fix(metadata): fix missing array cast for RDF types in ApiResource & ApiProperty constructors Sep 23, 2022
@soyuka
Copy link
Member

soyuka commented Sep 23, 2022

can you target 2.7 please?

@chalasr chalasr changed the base branch from 3.0 to 2.7 September 23, 2022 15:49
@chalasr
Copy link
Contributor Author

chalasr commented Sep 23, 2022

Done. Note that you may want to add the ?array type declaration on the $types property when merging up to 3.0.

@soyuka soyuka merged commit 603551a into api-platform:2.7 Sep 29, 2022
@soyuka
Copy link
Member

soyuka commented Sep 29, 2022

thanks @chalasr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants