3.1.11 - PUT does not work with ManyToMany deep nested relations

[mdieudonne]

API Platform version(s) affected: 3.1.11

Description
PATCH does not work with ManyToMany deep nested relations.
But now neither does PUT standard_put: true in 3.1.11

Possible Solution
Revert latest changes made in ItemNormalizer.php

[soyuka]

what because of ed4bca9 ?

or use standard_put: false?

[mdieudonne]

what because of ed4bca9 ?

or use standard_put: false?

To be honest, it's challenging for me to pinpoint the exact cause.
I only have limited knowledge about Api P.

I retried with standard_put: false but it doesn't seem to change a thing in the response I have:
Payload:

Response:

For info, in my case : I do need partial updates ("standard_put" === "legacy PUT").

[mdieudonne]

I also do have this behavior.
when submitting deep nested relations:

Payload:

Response:

3.1.11 + 'standard_put' => true || 'standard_put' => false
"Item not found for "/api/qual/qopse/fields/2123"."

3.1.10 + 'standard_put' => true || 'standard_put' => false
This is fine

[mdieudonne]

@soyuka Now if I retry my tests but reverting back this line in ItemNormalizer.php

$iri = $this->iriConverter->getIriFromResource($context['resource_class'], UrlGeneratorInterface::ABS_PATH, $operation, ['uri_variables' => ['id' => $data['id']]]);

Then this is fine in 3.1.11 too

[soyuka]

I tried to reproduce your issue without success, may you provide a reproducer?

[mdieudonne]

@soyuka
As previously said, if I modified ItemNormalizer as below, it works:

// $uriVariables = $this->getContextUriVariables($data, $operation, $context);
// $iri = $this->iriConverter->getIriFromResource($context['resource_class'], UrlGeneratorInterface::ABS_PATH, $operation, ['uri_variables' => $uriVariables]);
$iri = $this->iriConverter->getIriFromResource($context['resource_class'], UrlGeneratorInterface::ABS_PATH, $operation, ['uri_variables' => ['id' => $data['id']]]);

I've added data dumps in getContextUriVariables as below:

    private function getContextUriVariables(array $data, $operation, array $context): array
    {
        dump('$context[\'uri_variables\']', $context['uri_variables']);
        dump('$data[\'id\']',$data['id']);
        if (!isset($context['uri_variables'])) {
            return ['id' => $data['id']];
        }
        ....

And it seems the parent id is used instead of the nested id.
Am I doing something wrong?

[soyuka]

Thanks @mdieudonne I'll check we need to unset these variables once used. I'll work on a patch asap

[mdieudonne]

@soyuka I'd be glad to help and contribute, if you can drive me a bit on what needs to be done :)

[soyuka]

#5604 lmk if that works