Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1313 - LIMIT and ORDER BY on a column from a fetch joined to-many as… #1449

Closed
wants to merge 1 commit into from

Conversation

ambroisemaupate
Copy link
Contributor

LIMIT and ORDER BY on a column from a fetch joined to-many association

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1313
License MIT

@rlanting-move
Copy link

@ambroisemaupate Can you see if you can fix the code for travis so this can be merged?

@soyuka
Copy link
Member

soyuka commented Nov 2, 2017

@dunglas may you check this?

@meyerbaptiste
Copy link
Member

A unit test should be great!

@soyuka
Copy link
Member

soyuka commented Nov 2, 2017

@meyerbaptiste ok adding one today

soyuka pushed a commit to soyuka/core that referenced this pull request Nov 2, 2017
@soyuka
Copy link
Member

soyuka commented Nov 3, 2017

Merged in #1475 thanks @ambroisemaupate and @rlantingmove4mobile

@soyuka soyuka closed this Nov 3, 2017
soyuka added a commit that referenced this pull request Nov 3, 2017
Fix filter eager loading & merge #1449 + test
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants