-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swagger] Do not tag a sub-resource operation with child resource #1612
Conversation
Can you give more insight? Wouldn't it be more logicial to only tag the example with |
Actually, I opened this PR to get some feedback. I'm really not sure about this one ;) But for me it seems more logical to gather all root "resources" together as displayed on the screenshot. What do you think? |
I don't know what to think about this one. Both behaviors looks "logical" to me... Any feedback @api-platform/core-team? |
It all comes down to #1617 (comment) (same problematic). To me both are valid:
I'd even search for it in |
This looks way more logical to me as well 👍 Listing the same thing twice only confuses first-time API users who will go like "wait, I read this already". |
IMO, |
Okay for swagger. Though, were should be the subresource configuration (see api-platform/api-platform#529). To me it'd be easier to have it on the "Initiator" class. |
@lyrixx could you please update this according to the discussion ? |
Sure, But I don't know when. I should dedicate some time to work on API-Platform ;) |
@lyrixx when you can :p |
Closing in favor of #2706 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...
Before:
After: