fix FilterEagerLoadingExtension do not remove where clause if it did … #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
hotfix/filter-eager-loading-ext
branch
from
a04b31e
to
776f62d
Compare
sroze
reviewed
Jan 10, 2018
| } | ||
| } | ||
|
|
||
| if (false === $changedWhereClause) { |
There was a problem hiding this comment.
Can't you just check if the where clause of the query builder is empty instead of introducing a new variable?
There was a problem hiding this comment.
There's already a check for that here. This is really an edge case.
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…loading-ext fix FilterEagerLoadingExtension do not remove where clause if it did …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…not change