-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix property name in ContextAwareFilter to support GraphQL #1743
Conversation
GraphQL filter properties use a underscore instead of dot to seperate nested fields, which causes some issues like api-platform#1714 where nested filters are not applied. This change replaces the underscore with a dot in the AbstractContextAwareFilter to have one commen syntax further down. closes api-platform#1714
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test to prevent a future regression please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not the good way to fix this.
any suggestion how/were i should fix this? :) |
Using https://github.com/api-platform/core/blob/2.2/src/Util/RequestParser.php#L39 to retrieve the filters should do the trick. |
Hey, yes i did, but sadly got stuck in there and did not manage to fix it there :/ |
Did you push the WIP ? Ill try to help you ;). |
I think a better place to try fix it would be https://github.com/api-platform/core/blob/master/src/GraphQl/Resolver/Factory/CollectionResolverFactory.php#L80 |
This is fixed by @antograssiot. in #1868 Thanks anyway for this PR! |
GraphQL filter properties use a underscore instead of dot to separate nested fields, which causes some issues like #1714 where nested filters are not applied. This change replaces the underscore with a dot in the AbstractContextAwareFilter to have one common syntax further down.