[GraphQL] Only exposes the mutations if any #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
force-pushed
the
only-exposes-the-mutations-if-any
branch
from
caa7a35
to
152b643
Compare
dunglas
reviewed
Aug 28, 2018
src/GraphQl/Type/SchemaBuilder.php
Outdated
| 'mutation' => new ObjectType([ | ||
| ]; | ||
|
|
||
| if (\count($mutationFields) > 0) { |
dunglas
approved these changes
Aug 28, 2018
|
Maybe you could add a unit test or a Behat one (by using introspection)? |
sroze
force-pushed
the
only-exposes-the-mutations-if-any
branch
from
152b643
to
93c24ee
Compare
|
Rebased and changed check with a simple @alanpoulain based on the complexity of the |
|
Thanks @sroze |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, GraphiQL gives this lovely message: