Install phpstan locally and use extensions #2606
Conversation
teohhanhui
force-pushed
the
phpstan-shim-and-extensions
branch
from
198b9d1
to
37a2bf6
Compare
teohhanhui
force-pushed
the
phpstan-shim-and-extensions
branch
5 times, most recently
from
1b6f881
to
98cfc26
Compare
|
|
||
| if (!isset($item['data'])) { | ||
| throw new InvalidArgumentException('The JSON API document must contain a "data" key.'); | ||
| throw new UnexpectedValueException('The JSON API document must contain a "data" key.'); |
There was a problem hiding this comment.
I'd consider it a bug fix, because we're not supposed to throw this type of exception from NormalizerInterface::normalize in the first place.
|
title says |
|
@bendavies What do you mean? It does make the switch to phpstan-shim, which allows us to use extensions. That's very important as otherwise many problems go undetected. |
|
@teohhanhui where do you use the shim? i see |
|
@bendavies Oops. You're right. I didn't even realize that, but the intention was to use the shim. 😂😂😂 Yeah, I guess it's not actually necessary to use the shim. |
|
FYI here is why i'd advise against the shim: |
|
@bendavies That looks like a general Composer issue, but yeah, we have no need to use the shim, and could easily switch if / when the need arises. |
|
yes, it's a composer issue, but one that manifests if you use the shim, which is very annoying :) |
teohhanhui
force-pushed
the
phpstan-shim-and-extensions
branch
2 times, most recently
from
7bbfa76
to
e2874b4
Compare
teohhanhui
changed the title
Co-authored-by: soyuka <soyuka@users.noreply.github.com>
teohhanhui
force-pushed
the
phpstan-shim-and-extensions
branch
from
e2874b4
to
9352907
Compare
|
Thanks @teohhanhui ! |
Replaces #2603