Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pagination parameters in subresource docs #2698

Merged
merged 1 commit into from Apr 6, 2019

Conversation

Projects
None yet
5 participants
@Toflar
Copy link
Contributor

commented Apr 6, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1812
License MIT
Doc PR not needed

This is the updated PR from #1812. I'm sorry @RonRademaker I couldn't keep your commits separate and continue the work but instead I had to redo quite a bit because of the recent addition of OpenAPI Spec 3.0 support. I've made sure the commit is co-authored though so you get the attribution you deserve 馃槃
Thanks for the initial work!

@Toflar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Done at EUFOSSA Hackathon. Needs the label :)

@soyuka soyuka merged commit 5f7eaf3 into api-platform:master Apr 6, 2019

11 checks passed

Scrutinizer Analysis: 5 updated code elements 鈥 Tests: passed
Details
SymfonyInsight: dunglas / API Platform Core Code quality OK.
Details
ci/circleci: behat-coverage Your tests passed on CircleCI!
Details
ci/circleci: merge-and-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: php-cs-fixer Your tests passed on CircleCI!
Details
ci/circleci: phpstan Your tests passed on CircleCI!
Details
ci/circleci: phpunit-coverage Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.7%)
Details
codecov/project 95.7% (+<.01%) compared to ea2ea45
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@soyuka

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

thanks @Toflar !

@Toflar Toflar deleted the Toflar:subresource-pagination branch Apr 6, 2019

@alanpoulain

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

No unit test for this feature?

@dunglas

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

There is a functional test, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.