Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pagination parameters in subresource docs #2698

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

Toflar
Copy link
Contributor

@Toflar Toflar commented Apr 6, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1812
License MIT
Doc PR not needed

This is the updated PR from #1812. I'm sorry @RonRademaker I couldn't keep your commits separate and continue the work but instead I had to redo quite a bit because of the recent addition of OpenAPI Spec 3.0 support. I've made sure the commit is co-authored though so you get the attribution you deserve 😄
Thanks for the initial work!

@Toflar
Copy link
Contributor Author

Toflar commented Apr 6, 2019

Done at EUFOSSA Hackathon. Needs the label :)

@soyuka soyuka merged commit 5f7eaf3 into api-platform:master Apr 6, 2019
@soyuka
Copy link
Member

soyuka commented Apr 6, 2019

thanks @Toflar !

@Toflar Toflar deleted the subresource-pagination branch April 6, 2019 13:25
@alanpoulain
Copy link
Member

alanpoulain commented Apr 6, 2019

No unit test for this feature?

@dunglas
Copy link
Member

dunglas commented Apr 6, 2019

There is a functional test, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants