Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message in identifiers extractor #2713

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
5 participants
@Nek-
Copy link
Contributor

Nek- commented Apr 7, 2019

It was probably a bad copy/paste

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets None
License MIT
Doc PR N/A

@Nek- Nek- changed the title Fix error message in identifierextractor Fix error message in identifiers extractor Apr 7, 2019

@soyuka

This comment has been minimized.

Copy link
Member

soyuka commented Apr 8, 2019

tests need to be updated also

@@ -42,7 +42,7 @@ public function __construct(PropertyNameCollectionFactoryInterface $propertyName
$this->resourceClassResolver = $resourceClassResolver;
if (null === $this->resourceClassResolver) {
@trigger_error(sprintf('Not injecting %s in the CachedIdentifiersExtractor might introduce cache issues with object identifiers.', ResourceClassResolverInterface::class), E_USER_DEPRECATED);
@trigger_error(sprintf('Not injecting %s in the IdentifiersExtractor might introduce cache issues with object identifiers.', ResourceClassResolverInterface::class), E_USER_DEPRECATED);

This comment has been minimized.

Copy link
@teohhanhui

teohhanhui Apr 10, 2019

Member

It could be changed to use __CLASS__ instead? And remove "the".

This comment has been minimized.

Copy link
@Nek-

Nek- Apr 15, 2019

Author Contributor

Is it a must have?

@Nek- Nek- force-pushed the Nek-:patch-1 branch from 8e7e909 to 3fc52c6 Apr 11, 2019

@Nek-

This comment has been minimized.

Copy link
Contributor Author

Nek- commented Apr 15, 2019

CI didn't start or...?

Fix error message in identifierextractor
It was probably a bad copy/paste

@Nek- Nek- force-pushed the Nek-:patch-1 branch from 3fc52c6 to eb1ebf6 Apr 15, 2019

@soyuka soyuka merged commit 0665544 into api-platform:2.4 Apr 19, 2019

10 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
ci/circleci: behat-coverage Your tests passed on CircleCI!
Details
ci/circleci: merge-and-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: php-cs-fixer Your tests passed on CircleCI!
Details
ci/circleci: phpstan Your tests passed on CircleCI!
Details
ci/circleci: phpunit-coverage Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.82%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +4.17% compared to 39900b9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@soyuka

This comment has been minimized.

Copy link
Member

soyuka commented Apr 19, 2019

Thanks @Nek-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.