Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose iri subformat #3056

Closed
wants to merge 2 commits into from
Closed

Expose iri subformat #3056

wants to merge 2 commits into from

Conversation

bpolaszek
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

This PR adds the iri-reference subformat to OpenAPI for declared resources. Other PHP objects aren't affected by this extra information.

iri-reference

@bpolaszek
Copy link
Contributor Author

bpolaszek commented Sep 9, 2019 •
edited
Loading

FYI: Swagger validation passes for both versions 2 and 3, format being an arbitrary string with recommended values. See here and there.

dunglas
dunglas requested changes Sep 9, 2019
View reviewed changes
src/Bridge/Symfony/Bundle/Resources/config/json_schema.xml Outdated Show resolved Hide resolved
src/JsonSchema/TypeFactory.php Outdated Show resolved Hide resolved
src/JsonSchema/TypeFactory.php Outdated Show resolved Hide resolved
tests/JsonSchema/TypeFactoryTest.php Outdated Show resolved Hide resolved
@dunglas dunglas closed this Jan 23, 2021
@dunglas dunglas deleted the branch api-platform:master January 23, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas requested changes

@soyuka soyuka soyuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpolaszek @dunglas @soyuka