-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to local XSD #3218
Link to local XSD #3218
Conversation
This will allow IDEs to provide hints/ autocompletion
Thanks @BackEndTea |
Thanks @dunglas |
I think this change should be reverted... |
Does this change break anything for you? |
No, but see: https://www.jetbrains.com/help/phpstorm/referencing-xml-schemas-and-dtds.html This change seems unnecessary as the IDE can indeed work with remote XSD files. But I see this is following symfony/recipes#652 For a project that probably makes sense, but I'm not sure about a library... (What are the pros and cons?) |
One of the benefits is that there is no extra user interaction needed to get any kind of auto completion/ hints. Users would have to trigger that request themselves in order to get it. It is also possible that the link is referring to a version of the XSD that does not match the current one. Either we have an old link, or we link to a 'latest' version, which may be too new. There is also the danger that the link no longer works. Because we use the xsd phpunit provides us with, we always have the correct version, we don't need to make any additional HTTP requests, and we can even use its information if we are offline. |
Gotcha! We should cherry-pick this for |
This will allow IDEs to provide hints/ autocompletion
This will allow IDEs to provide hints/ autocompletion