Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace in namespace #3641

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Fix whitespace in namespace #3641

merged 1 commit into from
Jul 17, 2020

Conversation

pierredup
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Fix whitespace in namespace token.
If the RFC at https://wiki.php.net/rfc/namespaced_names_as_token gets accepted, then this will cause a parse error in PHP 8.

@alanpoulain alanpoulain merged commit d5a9276 into api-platform:2.5 Jul 17, 2020
@alanpoulain
Copy link
Member

Thanks!

@pierredup pierredup deleted the patch-1 branch July 17, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpoulain alanpoulain alanpoulain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierredup @alanpoulain