-
-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix tests #3688
Merged
Merged
fix: fix tests #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Aug 26, 2020
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tickets | n/a |
License | MIT |
Doc PR | n/a |
- Fix compatibility with Symfony 5.1
- Fix compatibility with recent PHPUnit version
dunglas
force-pushed
the
fix/tests-25
branch
2 times, most recently
from
August 27, 2020 14:23
ece4922
to
fad1c56
Compare
alanpoulain
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vincentchalamon
approved these changes
Aug 28, 2020
dunglas
added a commit
that referenced
this pull request
Aug 30, 2020
* 2.5: feat: bump JS deps Add changelog for 2.5.7 (#3691) fix: fix tests (#3688) Fix missing use statement (#3670) [MongoDB] Fix Behat tests (#3687) Fix missing Doctrine\Common\Persistence\ManagerRegistry class (#3684) [Swagger] Fix that subresource endpoints do not override custom endpoints #3676 - fixed subresource pagination support if primary resource has pagination disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.