Fix mising @type in output DTO collections #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/dtos
branch
2 times, most recently
from
3f920d6
to
4fda99c
Compare
dunglas
requested changes
Sep 1, 2020
| @@ -79,7 +79,7 @@ public function normalize($object, $format = null, array $context = []) | |||
| $context['api_empty_resource_as_iri'] = true; | |||
|
|
|||
| $data = $this->decorated->normalize($object, $format, $context); | |||
| if (!\is_array($data)) { | |||
| if (!\is_array($data) || !$data) { | |||
There was a problem hiding this comment.
You should test the type too (in case it's a string or another falsy value).
There was a problem hiding this comment.
It's an empty array because of the first part of the condition
soyuka
force-pushed
the
fix/dtos
branch
2 times, most recently
from
f9c985b
to
355bee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@typeproperty was missing from collection using output DTOs.