Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of deprecated DBAL type constants #4399

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

derrabus
Copy link
Contributor

Q A
Branch? 2.6
Tickets N/A
License MIT
Doc PR N/A

API platform references constants from Doctrine DBAL that have been deprecated two years ago (see doctrine/dbal#3356). Those constants have been removed in DBAL 3.0. At the moment, Doctrine ORM blocks the installation of DBAL 3, but this might change soon. This PR fixes all references and should prevent API platform applications from exploding once they bump DBAL beyond 3.0.

@derrabus derrabus changed the title Fix usage of deprecated DBAL type constants fix: usage of deprecated DBAL type constants Aug 30, 2021
@derrabus
Copy link
Contributor Author

The CI failures look unrelated.

@soyuka soyuka merged commit 86a2a4d into api-platform:2.6 Aug 31, 2021
@soyuka
Copy link
Member

soyuka commented Aug 31, 2021

thanks @derrabus

@derrabus derrabus deleted the bugfix/dbal-type-constants branch August 31, 2021 15:20
vincentchalamon pushed a commit to vincentchalamon/core that referenced this pull request Oct 15, 2021
vincentchalamon pushed a commit to vincentchalamon/core that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants