fix(testClient): Support REMOTE_ADDR header #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Sep 14, 2021
|
Could you add a unit test to prevent any regression? |
alanpoulain
force-pushed
the
fix-client
branch
from
e7f09f1
to
547b93b
Compare
|
Thanks @ilicmsreten. |
vincentchalamon
pushed a commit
to vincentchalamon/core
that referenced
this pull request
Oct 15, 2021
Co-authored-by: Alan Poulain <contact@alanpoulain.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header
REMOTE_ADDRis prefixed withHTTP_although Symfony use header without prefix