Add metadata caching #469
Merged
Add metadata caching #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teohhanhui
force-pushed
the
metadata-cache
branch
from
3d3016e
to
a0fe215
Compare
|
I easily get more than 10x performance improvement on a collection get of 30 items. |
teohhanhui
force-pushed
the
metadata-cache
branch
3 times, most recently
from
0d61a40
to
e935bf3
Compare
| */ | ||
| public function create(string $resourceClass, array $options = []) : PropertyNameCollection | ||
| { | ||
| $cacheKey = self::CACHE_KEY_PREFIX.md5(json_encode([$resourceClass, $options])); |
There was a problem hiding this comment.
I gave that some thought too, but json_encode produces shorter output. We could always improve on this later on if the performance difference is substantive?
There was a problem hiding this comment.
Switched to sha1 since it's (surprisingly) faster than md5 (at least that's what openssl speed md5 sha1 shows on my machine and a Digital Ocean droplet).
There was a problem hiding this comment.
Oops, that's not the case in PHP. Let's switch back to md5.
|
👍 except for the last comment I made. Good job thank you very much!! |
teohhanhui
force-pushed
the
metadata-cache
branch
6 times, most recently
from
518fd6d
to
16cb4f8
Compare
|
ping @api-platform/core-team |
teohhanhui
force-pushed
the
metadata-cache
branch
from
16cb4f8
to
a8eec5c
Compare
|
Thank you @teohhanhui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PSR6 cached decorators for all metadata factories.
Also provide
symfony/cacheintegration in the Symfony bundle.